I cough up yellow flem and it has a bad smell?

If your mucus is any color but clear, that means infection. Go to the doc and get some antibiotics.